feat: Allow exclude list of categories #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: Always include categories argument, even if none are provided
Co-authored-by: Jonathan Herbert <jonathan.herbert@guardian.co.uk> Co-authored-by: Samantha Gottlieb <samantha.gottlieb@guardian.co.uk>
…t of categories Co-authored-by: Jonathan Herbert <jonathan.herbert@guardian.co.uk> Co-authored-by: Samantha Gottlieb <samantha.gottlieb@guardian.co.uk>
jonathonherbert
approved these changes
Sep 8, 2023
Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
Co-authored-by: Jonathon Herbert <jonathon.herbert@guardian.co.uk>
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Allow an exclude list of categories rather than allowing only an allowlist.
This means that, in order to an exclude an existing category (i.e. the dictionary category) from a consumer (i.e. Composer), we don't have to fetch the categories, filter it out, then add them to a
MatcherService- which also means we can initialised theprosemirrorTyperighterPlugin, in order to apply the exclusions to the first request (preventing a race condition where we initialised the plugin, get the matcher service, then request a category change).Dependant on a change in
typerighter.How to test
prosemirror-typerighterlocally using this branch and use inflexible-contentwithyalc(npm run yalcinprosemirror-typerighterthenyalc add @guardian/prosemirror-typerighterinflexible-content.