New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use header convention for identifying request #46

Open

jonathonherbert opened this issue Jun 2, 2020 · 0 comments

Contributor

jonathonherbert commented Jun 2, 2020

At the moment, we store the requestId for typerighter match requests in the body of the JSON we send.

The method we use elsewhere is an X-GU-LoggingContext header. See https://github.com/guardian/flexible-content/blob/master/flexible-content-common/src/main/scala/com/gu/flexiblecontent/util/LoggingContext.scala and https://github.com/guardian/flexible-content/blob/master/composer/src/js/app.js#L393-L419

It'd be good to use this convention for ease of debugging across projects.

We could also include contentId there, and sessionId if we can access it.

jonathonherbert mentioned this issue

Fetch typerighter matches for the current search #44

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment