critical fixes to SSL cert verification in StrongTrustManager #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
n8fr8
commented
Mar 11, 2013
n8fr8
commented
- ensure BasicConstraints exists and are CA:TRUE for all signing/issuer certs in chain.
- ensure KeyUsage is set to proper values (signing capable, etc)
- small optimization of only loading StrongTrustManager once
- ensure cert SN/DN is not duplicated, and all instances in chain that act as issuers have right to do so
will investigate using moxie's new libpinning library
check entire chain for multiple instances of CN/DN to ensure they are allowed to be issuer/CA/signer
ghost
assigned
n8fr8
added a commit
that referenced
this pull request
Mar 13, 2013
critical fixes to SSL cert verification in StrongTrustManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.