Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there are many mistaks in source code, will my effort be merged? #57

Closed
ertosns opened this issue Oct 25, 2016 · 2 comments
Closed

there are many mistaks in source code, will my effort be merged? #57

ertosns opened this issue Oct 25, 2016 · 2 comments

Comments

@ertosns
Copy link

ertosns commented Oct 25, 2016

my first time to participate to open source.
I don't know if changes could easily get merged to main project (after reviewing)

reading through the source many bad practises, bad styling, unused code(many), and nonsense code like defining public final static in interface.

should I change any mistake will my changes be reviewed and merged to main project?

@arrase
Copy link
Contributor

arrase commented Nov 30, 2016

IMO you are right, there some ugly blocks of code but in other hand a massive refactor of the project can be a conflicts nightmare for other contributors, and would be a very unpopular measure

I think than projects like this, who has a very common IDE for developers with capability to auto-indent and code formating, should share a file with the configurarion of the code style for import into IDE.

That was always a friction point in all the projects i ever collaborate.

My advice is do not do it though it would be nice in a perfect future :)

@n8fr8
Copy link
Member

n8fr8 commented Jun 1, 2017

Over time let's all work toward better styling and formatting, but yes, not all at once!

@n8fr8 n8fr8 closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Orbot Test Project
Developer Support
Development

No branches or pull requests

3 participants