Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Split up utils in repository #2792

Merged
merged 1 commit into from Jan 6, 2023
Merged

Conversation

VakarisZ
Copy link
Contributor

@VakarisZ VakarisZ commented Jan 6, 2023

What does this PR do?

Splits up utilities in repositories package

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running unit tests

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 64.19% // Head: 64.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (44d61c1) compared to base (5e903a8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2792   +/-   ##
========================================
  Coverage    64.19%   64.20%           
========================================
  Files          404      406    +2     
  Lines        11569    11572    +3     
========================================
+ Hits          7427     7430    +3     
  Misses        4142     4142           
Impacted Files Coverage Δ
...nkey/monkey/monkey_island/cc/repositories/utils.py
...d/cc/repositories/utils/machine_repository_init.py 57.14% <0.00%> (ø)
...ey/monkey_island/cc/repositories/utils/__init__.py 100.00% <0.00%> (ø)
...nkey_island/cc/repositories/utils/mongo_encoder.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mongo_dot_encoder,
)
from monkey_island.cc.repositories.utils import mongo_dot_decoder, mongo_dot_encoder
from monkey_island.cc.repositories.utils.mongo_encoder import DOT_REPLACEMENT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorten the import for mongo_encoder.

Copy link
Contributor Author

@VakarisZ VakarisZ Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOT_REPLACEMENT is not part of the package interface, because it's not used (and probably shouldn't be used) outside of the package

@VakarisZ VakarisZ merged commit cbacbc7 into develop Jan 6, 2023
@VakarisZ VakarisZ deleted the 2783-split-up-utils branch January 6, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants