Fixing issues related to old PR #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my bad! sorry!
|
i've also fixed this for the 1.16 version of the mod, but since your repo doesn't have a branch for it, i couldn't figure out how to PR that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #8 i sought to fix a quantity of off-by-one rendering errors.
as it turns out, there was actually only one error. under the assumption there were multiple, i had originally pushed a bunch of textures 1 pixel in the wrong direction, in the interest of manually tweaking alignment.
these textures were aligned, but in some hotbar modes, the hotbar was 1 pixel higher than it appeared in vanilla.
so, this PR undoes those old changes, and fixes the error in the correct place. for real this time. largebar should, hopefully for good, be completely indistinguishable from vanilla's hotbar.
whoops! sorry!