Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake - TBB] TBB requires to link against libatomic on some non-x86_64 architectures #26

Closed
VincentRouvreau opened this issue Mar 7, 2019 · 3 comments
Labels
build The build system (CMake, etc)

Comments

@VincentRouvreau
Copy link
Contributor

Some non-x86_64 architectures seem to require explicitly linking against libatomic for the things that use TBB. I'm currently just adding it to the list of TBB libraries. Perhaps CMake can do something more intelligent on the architectures where it's needed?
https://git.nonempty.org/debian-gudhi/tree/debian/patches/0007-Force-linking-against-libatomic-for-parts-that-use-T.patch?h=debian/sid&id=fed62e52ab396f0d6ba9029f12d5ef35d7761989

@mglisse mglisse added the build The build system (CMake, etc) label Nov 15, 2019
@VincentRouvreau
Copy link
Contributor Author

@gspr Is this issue still relevant ?
I checked in other FindTBB.cmake files like the one in CGAL or this one and they never link against libatomic.
I also checked TBB release notes and TBB issue tracker and it is not clear to me when we need to link against libatomic

@gspr
Copy link
Contributor

gspr commented Jan 22, 2021 via email

@VincentRouvreau
Copy link
Contributor Author

Thanks for the test, I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build system (CMake, etc)
Projects
None yet
Development

No branches or pull requests

3 participants