Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend -DCMAKE_BUILD_TYPE=Release #87

Closed
mglisse opened this issue Sep 3, 2019 · 2 comments
Closed

Recommend -DCMAKE_BUILD_TYPE=Release #87

mglisse opened this issue Sep 3, 2019 · 2 comments
Labels
doc A documentation issue

Comments

@mglisse
Copy link
Member

mglisse commented Sep 3, 2019

In the documentation (say python installation), we show commands to build gudhi, and in particular we show cmake ... Doing this, we get the "CGAL performance notice" which recommends adding -DCMAKE_BUILD_TYPE=Release. Should we add this argument in the doc? Or if for some reason it does not apply, should we disable the warning with CGAL_DO_NOT_WARN_ABOUT_CMAKE_BUILD_TYPE=TRUE?
@mglisse mglisse added the doc A documentation issue label Nov 11, 2019
@VincentRouvreau
Copy link
Contributor

Does it really affect CGAL performances if we do not set CMAKE_BUILD_TYPE ?
(or if we set CGAL_DO_NOT_WARN_ABOUT_CMAKE_BUILD_TYPE=TRUE)

@VincentRouvreau VincentRouvreau mentioned this issue Mar 9, 2020
Open
@VincentRouvreau VincentRouvreau mentioned this issue Aug 21, 2020
Merged
@VincentRouvreau
Copy link
Contributor

Closed by #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc A documentation issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mglisse @VincentRouvreau