Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match strict equivalent modules from Perl::Critic #21

Merged
merged 3 commits into from Aug 23, 2021

Conversation

ferki
Copy link
Contributor

@ferki ferki commented Apr 17, 2021

This is an attempt to fix #20 by reusing the list of strict equivalent modules from Perl::Critic::Utils::Constants.

Since Test2::V0 is not included there (yet?), I've also added an explicit test case for it to make sure it remain compatible with the previous list of modules on this side.

I hope this idea is useful; please review and merge, or let me know how to improve it further.

@gugod gugod merged commit 8e0da32 into gugod:master Aug 23, 2021
@gugod
Copy link
Owner

gugod commented Aug 23, 2021

@ferki Thank you for your works! It is indeed a good idea to avoid duplicate works, especially when the same list is already defined in Perl::Critic. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse list of strict equivalent modules from Perl::Critic
2 participants