Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Birb can't add feed if it has invalid XML characters #12

Open
bannmann opened this issue Jan 4, 2024 · 5 comments
Open

Birb can't add feed if it has invalid XML characters #12

bannmann opened this issue Jan 4, 2024 · 5 comments
Labels
feature New feature or request

Comments

@bannmann
Copy link

bannmann commented Jan 4, 2024

Requested feed: https://www.captain-futura.de/feed/

Birb responds:

Hm, I can't find a feed for this site.

Taking the "for this site" part verbatim, I also tried to enter the site URL https://www.captain-futura.de/ instead of its feed URL, but got the same result.

@gugray gugray added the feature New feature or request label Jan 8, 2024
@gugray
Copy link
Owner

gugray commented Jan 8, 2024

It appears the feed contains an invalid character. Go's built-in XML parser is pretty finicky about this, so it complains with this error: XML syntax error on line 535: illegal character code U+0003

I've seen this in about 3% of the 10k+ feeds from the Kagi Small Web that I imported before the release. I'll get back to this later and look for a way to sanitize the input if it has this kind of easy-to-fix problems.

@gugray gugray changed the title Birb can't find a feed although it exists Birb can't add feed if it has invalid XML characters Jan 8, 2024
@gwater
Copy link

gwater commented Jan 17, 2024

I suspect this is also messing with youtube's atom feeds at the moment.

For example, this youtube feed was set up a while ago and apparently works fine

https://rss-parrot.net/web/feeds/www.youtube.com.channel.ucb9awk0xfz2p-ny2nsxghra

however new youtube feeds get the

Hm, I can't find a feed for this site.

response

@FueledxJarritos
Copy link

Also confirming that it's affecting Youtube feeds

@gugray
Copy link
Owner

gugray commented Jan 23, 2024

Youtube problem is unrelated, opening a different issue for it.

@eiland-asbl
Copy link

This feed also isn't accepted: https://fd.nl/?rss
Would be nice if it would eturn that a feed /is/ found but that it can't be processed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants