Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the PowerShell modules arch-agnostic for now #3559

Closed
dodexahedron opened this issue Jun 23, 2024 · 3 comments
Closed

Make the PowerShell modules arch-agnostic for now #3559

dodexahedron opened this issue Jun 23, 2024 · 3 comments
Assignees
Labels
v2 For discussions, issues, etc... relavant for v2 work-in-progress
Milestone

Comments

@dodexahedron
Copy link
Collaborator

dodexahedron commented Jun 23, 2024

I did that on purpose because I didn't intend to support it where VS can't run.

You don't have to pre-build the analyzers to do a CLI build.

However, I don't currently have any hard requirements in the modules on CPU architecture. I'd just have to make a platform check in the places where VS is launched to skip them or let the user eat the error themselves. 🤷‍♂️

Originally posted by @dodexahedron in #3477 (comment)

@dodexahedron
Copy link
Collaborator Author

Simple enough and not a big deal at the moment.

I'll change the module manifest to allow at least Arm for now.

@dodexahedron dodexahedron self-assigned this Jun 23, 2024
@dodexahedron dodexahedron added work-in-progress v2 For discussions, issues, etc... relavant for v2 labels Jun 23, 2024
@dodexahedron dodexahedron added this to the V2 Alpha milestone Jun 23, 2024
@dodexahedron
Copy link
Collaborator Author

Actually... Looking at the module manifest, architecture isn't specified right now. I wonder why you are getting that message @tig

@dodexahedron
Copy link
Collaborator Author

Ah, I see. You had already committed the change to v2_develop.

That's fine and takes care of this for now.

Remember you don't need to run that cmdlet to build anywhere except visual studio.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 For discussions, issues, etc... relavant for v2 work-in-progress
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant