Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust glucose limits #6

Closed
wants to merge 1 commit into from
Closed

chore: adjust glucose limits #6

wants to merge 1 commit into from

Conversation

3djc
Copy link
Contributor

@3djc 3djc commented Nov 14, 2023

Match 'normal' glucose range of 80-120

@3djc 3djc changed the title chore: more sensible glucose limits chore: adjust glucose limits Nov 14, 2023
@gui-dos
Copy link
Owner

gui-dos commented Nov 14, 2023

This is not a medical recommendation but a mere UI choice: 99 is just the maximum 2-digit number that doesn’t make the labels move :-)

SwiftUI doesn’t let you customize easily like in UIKit the colors of both the left and the right segments of a slider since there is no SliderStyle: a more ideal solution would be to use a single slider with four thumbs, the center target range colored in green and red alarms thresholds at the margins but without wrapping an UISlider in a UIViewRepresentable.

I am optimizing the SettingsView to be controlled comfortably at the thumb’s reach, without needing to scroll it: in smaller displays thumbs cannot be accurate so I am leaving some leeway purposely.

@3djc
Copy link
Contributor Author

3djc commented Nov 14, 2023

Ok for 99, but why start at 140 lowest then (my alarms are set at 75/130 :) )

@gui-dos
Copy link
Owner

gui-dos commented Nov 14, 2023

OK. 239cd0a lowers to 120 the targetHigh / alarmHigh sliders low ends.

Since our Vendor is targeting also athletes with the Biosensors and supporting all those “metabolic health” startups (I was contacted already by a dozen of them), let’s support them, too ;-)

@3djc
Copy link
Contributor Author

3djc commented Nov 14, 2023

Works for me !

@3djc 3djc closed this Nov 14, 2023
@3djc 3djc deleted the minor-limit-changes branch November 15, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants