Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the expression type support audio? #17

Open
Vepnar opened this issue Oct 24, 2021 · 4 comments
Open

Does the expression type support audio? #17

Vepnar opened this issue Oct 24, 2021 · 4 comments
Labels
enhancement ➕ New feature or request

Comments

@Vepnar
Copy link

Vepnar commented Oct 24, 2021

Configuration similar to the audio settings of vocabulary type would be nice. I tried adding copy the settings with no success.

{
    "packages": [
        {
            "name": "english",
            "decks": [
                {
                    "id": "b698a07e-70eb-474b-82cb-f244a608b21e",
                    "name": "English",
                    "src": [
                        {
                            "type": "expression",
                            "file": "expressions.tsv",
                            "header": true,
                            "card_color": "#AA3333",
                            "card_properties": {
                                "tags": ["english", "expressions"]
                            }
                        }
                    ],
                    "audio": {
                        "lang": "en",
                        "media_dir": "./media"
                    }
                }
            ]
        }
    ]
}
@Otter-man
Copy link
Contributor

@Vepnar nope, expression type doesn't support audio generation.

@Vepnar
Copy link
Author

Vepnar commented Oct 28, 2021

If I download the audio myself. Can I link the audio easily with the cards?

@Otter-man
Copy link
Contributor

Otter-man commented Nov 1, 2021

@Vepnar

If I download the audio myself. Can I link the audio easily with the cards?

No, so far mnemocards allow audio only for vocabulary and autogenerated types and only generated by google.
There is no way currently to add audio (even if you downloaded it beforehand) to other card types during generation. You can only add audio manually after creating a deck through anki interface.

I'll look into it though and maybe in the following month add support for user-created audio for markdown type and autogeneration audio for expression.

However mnemocards maintainer @guiferviz is seem to be busy with other projects so approving of pull requests might take some time. In the meantime, if I add audio support as you ask about - I'll do it in my own fork and will send you a mention.

@guiferviz
Copy link
Owner

Hi @Vepnar , as @Otter-man said there is not support for audio generation in expression cards.

I'll be a bit more free for the next few months, I'll design what I want to have in version 1.0 during the next few days and post it somewhere in GitHub, in case you're interested. In a nutshell the changes will be mostly a refactor so that anyone can easily create plugins (card types, like vocabulary, expressions and cards) and also modify the style of the cards without having to modify the library code.

Thanks again for your support @Otter-man .

@guiferviz guiferviz added the enhancement ➕ New feature or request label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants