Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change build output for for example direct browser support #231

Closed
mathe42 opened this issue Aug 3, 2021 · 2 comments
Closed

change build output for for example direct browser support #231

mathe42 opened this issue Aug 3, 2021 · 2 comments

Comments

@mathe42
Copy link
Contributor

mathe42 commented Aug 3, 2021

I think it would be nice to provide a dist file wich runs directly in browser from for example https://unpkg.com/docx-templates@4.7.0?module. unpkg is cool as it rewrites imports to modules with real urls.

If interessted I would create a PR adds some build scripts to add a esm output in the next days.

This would be completely seperated or can be added in the package.json module field.

@jjhbw
Copy link
Collaborator

jjhbw commented Aug 4, 2021

That'd be great. I'm not really familiar with that space, and every time I have to work on toolchain stuff I feel like throwing my computer out of the window.

We had some problems before in creating a 'pure' browser build that is ready to use, as some deps require pretty advanced polyfills. Maybe related: #135.

@jjhbw
Copy link
Collaborator

jjhbw commented Aug 6, 2021

Implemented in 3d6c1a8

@jjhbw jjhbw closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants