Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forget items from leaves of tree upwards #23

Closed
masaeedu opened this issue Oct 30, 2017 · 2 comments
Closed

Forget items from leaves of tree upwards #23

masaeedu opened this issue Oct 30, 2017 · 2 comments

Comments

@masaeedu
Copy link

When the chrome extension starts forgetting items due to the predefined limit, it often starts with the top level parent stories that provide structure to the rest of what's going on. This usually results in nonsensical, confusing output.

When stuff is being forgotten, it should start with the log items from the leaf stories (say, an even selection of the oldest log items from every leaf story). Only once a story has no more children should it be deleted.

@guigrpa
Copy link
Owner

guigrpa commented Nov 7, 2017

Hi, and thanks for the report!

Could you maybe share some steps to reproduce, or maybe screenshots of what you mean? Even better: maybe you could consider adding a failing test to the suite? In principle (see this test), the forgetting algorithm should work just as you describe…

@guigrpa
Copy link
Owner

guigrpa commented Jan 16, 2018

Closed due to inactivity. Please reopen if the problem comes back.

@guigrpa guigrpa closed this as completed Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants