New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide file names when "Failed to process {len(self.discovery.failures)} files" is returned #18
Comments
Good point. |
I think that's a great idea! If you'd like I can try and make and update and submit a PR. It would be a couple of days though before I was able to get the PR submitted. |
@guilatrova I tried to get the project set up and installed locally in edit mode (
What is the set up you use when developing locally. Perhaps I'm just missing something obvious. Thanks! |
@ryancheley Thanks for the help! I created a short new contributing doc, can you check and let me know if it works for you? |
@guilatrova I've made the changes and pushed them to my fork of the repo. Before I create a pull request, do you want to look at the changes I made? If so, you can see them here If not, just let me know and I'll create the PR Thanks! |
That's a great start and thanks for following the conventions! I think we can go even beyond though! I'd love to make your change so impactful that it can benefit other developers/contributors in the future. How? Here: Verbose means that any "verbose" (duh) message gets displayed in the console, besides the final user presentation (that we do with I'd recommend then: Extend
|
I really like the ideas above and can work on implementing something this week. I'll need to look more closely at the try / except in It seems like it's doing exactly what a try/except should be doing and I'm not aware of any other mechanisms to handle what it's doing (though maybe there is something?) I'll continue to work on the branch of my fork and won't submit a PR for now. Thanks! P.S. I'd also love to have my name as a contributor on this project 😄 |
@guilatrova I think I have it figured out (also, I understand what you were asking about when you mentioned I did swap out the My changes are located here. There are still tests that need to be written for this change, but I wanted to get your input before starting to write the tests Thanks! |
Yes, you got the idea! Please open a PR so we can start discussing there |
When running
tryceratops
if any of the files aren't able to process, more information should be returned about which files can't be processed.Specifically, running
tryceratops
on a simple project with only 16 files returns the following:Without knowing which file failed to process, I'm not sure what, if anything, I should do for next steps.
This message comes from interfaces.py line 51
The text was updated successfully, but these errors were encountered: