Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Click 8 #39

Merged
merged 1 commit into from Nov 19, 2021
Merged

Allow Click 8 #39

merged 1 commit into from Nov 19, 2021

Conversation

paw-lu
Copy link
Contributor

@paw-lu paw-lu commented Nov 19, 2021

Current Click specification actually disallows Click ^8. This is causing dependency issues for me. This PR loosens the requirements to allow ^8 and ^7. This might not actually be desired, and we might want to constrain to ^8.0, but wanted to keep changes to a minimum for now. All tests are passing on Click 8.0.3.


Thanks for the project!

@guilatrova
Copy link
Owner

I'm going to test it locally to validate.
Thanks for your contribution ❤️

Note that using chore (which is correct and a good decision, thank you for following the guidelines!) won't trigger a new release. Would it be problematic for you?

@guilatrova
Copy link
Owner

Another thought... It might be safer to limit it to version 8 as well

@guilatrova
Copy link
Owner

@paw-lu can you adjust it to: click = ">= 7,< 9" ? I check the 8.x version and it worked fine, so I believe we're good :)

@paw-lu paw-lu changed the title Allow Click ^8 Allow Click 8 Nov 19, 2021
@paw-lu
Copy link
Contributor Author

paw-lu commented Nov 19, 2021

@paw-lu can you adjust it to: click = ">= 7,< 9" ? I check the 8.x version and it worked fine, so I believe we're good :)

Done!

Note that using chore (which is correct and a good decision, thank you for following the guidelines!) won't trigger a new release. Would it be problematic for you?

If possible, a patch release would be appreciated to solve immediate issues.

@guilatrova guilatrova merged commit d336d8b into guilatrova:main Nov 19, 2021
@guilatrova
Copy link
Owner

If possible, a patch release would be appreciated to solve immediate issues.

I agree since it looks like #34 is close to an end, I'll wait a bit to make the releases less noisy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants