Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix Missing RateControl element in Tenvis cameras #29

Open
skitsanos opened this issue Apr 28, 2018 · 1 comment
Open

Quick fix Missing RateControl element in Tenvis cameras #29

skitsanos opened this issue Apr 28, 2018 · 1 comment

Comments

@skitsanos
Copy link

Hi there,

Just wanted to let you know that Tenvis cameras are not sending RateControl data that becomes a reason for your lib to fire an error.

I've fixed the issue through this (code from line 636 and further):

if (p.VideoEncoderConfiguration.RateControl === undefined)
                    {
                        p.VideoEncoderConfiguration.RateControl = {
                            FrameRateLimit: 10,
                            BitrateLimit: 10
                        };
                    }

                    profile['video']['encoder'] = {
@skitsanos
Copy link
Author

Issue still exists on the newer version... Lines 665 and 665 on device.js, fixed it with the following:

'framerate': (p['VideoEncoderConfiguration']['RateControl'] == undefined) ? 10 : parseInt(p['VideoEncoderConfiguration']['RateControl']['FrameRateLimit'], 10),
                        'bitrate': (p['VideoEncoderConfiguration']['RateControl'] == undefined) ? 10 : parseInt(p['VideoEncoderConfiguration']['RateControl']['BitrateLimit'], 10),
                        

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant