Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Builder inherits from Plotter #32

Closed
GuillaumeFavelier opened this issue May 30, 2020 · 0 comments
Closed

Make Builder inherits from Plotter #32

GuillaumeFavelier opened this issue May 30, 2020 · 0 comments
Labels
enhancement New feature or request refactor Change the code but not the features
Projects
Global Roadmap
Milestone
Release 0.4

Comments

@GuillaumeFavelier
Copy link
Owner

GuillaumeFavelier commented May 30, 2020 •
edited
Loading

The end gold is to set up the project as an app.

A good way to achieve this is to make Builder inherits from Plotter and Plotter inherits directly from QMainWindow.

That way, one Builder instance contains all the informations needed without the need to use association. It's then easier to maintain and configure.

This change requires #6
@GuillaumeFavelier GuillaumeFavelier created this issue from a note in Global Roadmap (In Progress) May 30, 2020
@GuillaumeFavelier GuillaumeFavelier added this to the Release 0.4 milestone May 30, 2020
@GuillaumeFavelier GuillaumeFavelier added the enhancement New feature or request label May 30, 2020
@GuillaumeFavelier GuillaumeFavelier moved this from In Progress to Done in Global Roadmap May 30, 2020
@GuillaumeFavelier GuillaumeFavelier added the refactor Change the code but not the features label May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor Change the code but not the features
Projects
Global Roadmap
  
Done
Milestone
Release 0.4
Development

No branches or pull requests
1 participant
@GuillaumeFavelier