Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_random_n_shapes in DiagramGenerator.py #1

Open
guillesanbri opened this issue Aug 24, 2021 · 0 comments
Open

get_random_n_shapes in DiagramGenerator.py #1

guillesanbri opened this issue Aug 24, 2021 · 0 comments

Comments

@guillesanbri
Copy link
Owner

This method is fixed on 5 as the current default values to generate the size of a shape (max) is
min_size_diagram2(1+1.5)/n_shapes
and therefore if the n_shapes is less than 5 the shape can be bigger than the diagram, raising an error in the random integer method. However, if this default values change this method will break.

TODO: Link this method to the size formula in SyntheticDiagram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant