Remove lodash modules #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
requested changes
Feb 25, 2017
lib/helpers.js
Outdated
| @@ -25,8 +25,12 @@ function buildOnSettled(done) { | |||
| return done(error, null); | |||
| } | |||
|
|
|||
| var settledErrors = filter(result, { state: 'error' }); | |||
| var settledResults = filter(result, { state: 'success' }); | |||
| var settledErrors = filter(result, function(elem) { | |||
There was a problem hiding this comment.
This anonymous function used as the 2nd parameter to filter can be a named function and moved to the top level (similar to the getExtensions function above)
You can probably name it filterError
lib/helpers.js
Outdated
| var settledErrors = filter(result, function(elem) { | ||
| return elem.state === 'error'; | ||
| }); | ||
| var settledResults = filter(result, function(elem) { |
There was a problem hiding this comment.
This anonymous function used as the 2nd parameter to filter can be a named function and moved to the top level (similar to the getExtensions function above)
You can probably name it filterSuccess
| "arr-filter": "^1.1.1", | ||
| "arr-flatten": "^1.0.1", | ||
| "arr-map": "^2.0.0", | ||
| "array-each": "^0.1.1", |
There was a problem hiding this comment.
I opened an issue on array-each to bump to 1.0 - ref jonschlinkert/array-each#1
Hoping to get that bumped before merging this.
phated
approved these changes
Feb 26, 2017
phated
pushed a commit
that referenced
this pull request
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #28
Remove lodash modules, and replace them with:
flatten: https://github.com/jonschlinkert/arr-flattenmap: https://github.com/jonschlinkert/arr-maplast: https://github.com/jonschlinkert/array-lastfilter: https://github.com/jonschlinkert/arr-filtereach: https://github.com/jonschlinkert/array-eachinitial: https://github.com/jonschlinkert/array-initial