Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp should use current locale #17

Closed
felixfbecker opened this issue Oct 7, 2018 · 2 comments
Closed

Timestamp should use current locale #17

felixfbecker opened this issue Oct 7, 2018 · 2 comments

Comments

@felixfbecker
Copy link

Here's tsc's output (with --pretty) in the US, Australia, India or other countries that use the 12h system:

[3:24:45 PM] File change detected. Starting incremental compilation...
[3:24:45 PM] Found 0 errors. Watching for file changes.

Here's gulp's:

[15:24:31] Requiring external module ts-node/register
[15:24:33] Using gulpfile ~/test/gulpfile.ts
[15:24:33] Starting 'sass'...

Different countries have different ways to format the time. fancy-log currently uses the time-stamp module and hard-codes the timestamp format to be HH:mm:ss. Instead, it should simply use new Date().toLocaleTimeString(), which respects the user's locale.

@phated
Copy link
Member

phated commented Oct 7, 2018

No thanks.

@phated phated closed this as completed Oct 7, 2018
@felixfbecker
Copy link
Author

felixfbecker commented Oct 7, 2018

But why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants