Fixed issue #2 #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, didn't realize the two commits got placed in the same pull request. Well, anyway.. |
|
Thanks for this fix. Can you change the unit tests in a separate PR so I can review them independently? Thanks! |
|
Cleaned up ths PR, will add another for tests. |
|
👍 I was about to fork and submit this same PR. :) |
cowboy
pushed a commit
that referenced
this pull request
Mar 8, 2013
|
Closed in 35a3ab5. |
This was referenced Mar 8, 2013
phated
pushed a commit
that referenced
this pull request
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.resolve does not allow first argument to be anything other than string if it present.
would also work