Fix: Upgrade glob-parent to fix incorrect base when parens in glob pa…

…th (closes #70)
gulpjs · Feb 21, 2017 · d611fdd · d611fdd
1 parent 558be7a
commit d611fdd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -23,7 +23,7 @@
   "dependencies": {
     "extend": "^3.0.0",
     "glob": "^5.0.3",
-    "glob-parent": "^2.0.0",
+    "glob-parent": "^3.0.0",
     "micromatch": "^2.3.7",
     "ordered-read-streams": "^0.3.0",
     "through2": "^0.6.0",

diff --git a/test/main.js b/test/main.js
@@ -80,6 +80,24 @@ describe('glob-stream', function() {
       });
     });
 
+    it('should set the correct base when ( ) in glob', function(done) {
+      var stream = gs.create('./fixtures/has (parens)/*.dmc', { cwd: __dirname });
+      should.exist(stream);
+      stream.on('error', function(err) {
+        throw err;
+      });
+      stream.on('data', function(file) {
+        should.exist(file);
+        should.exist(file.path);
+        should.exist(file.base);
+        should.exist(file.cwd);
+        String(file.cwd).should.equal(__dirname);
+        String(file.base).should.equal(join(__dirname, 'fixtures/has (parens)/'));
+        String(join(file.path,'')).should.equal(join(__dirname, './fixtures/has (parens)/test.dmc'));
+        done();
+      });
+    });
+
     it('should find files in paths that contain ( )', function(done) {
       var stream = gs.create('./fixtures/**/*.dmc', { cwd: __dirname });
       var files = [];