Support custom 'unique' filtering through option #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a nice win for API flexibility, lgtm! |
phated
requested changes
Feb 25, 2017
README.md
Outdated
| @@ -90,6 +90,14 @@ Type: `Boolean` | |||
|
|
|||
| Default: `false` | |||
|
|
|||
| ##### `options.unique` | |||
|
|
|||
| Filters stream to remove duplicates based on `unique`. | |||
There was a problem hiding this comment.
Maybe something like "based on the string property name or the result of function". It should also be mentioned that when using a function, it receives the streamed data to compare against (we refer to this data above as "objects that contain cwd, base and path properties")
index.js
Outdated
| @@ -20,6 +20,8 @@ function globStream(globs, opt) { | |||
| ourOpt.dot = typeof ourOpt.dot === 'boolean' ? ourOpt.dot : false; | |||
| ourOpt.silent = typeof ourOpt.silent === 'boolean' ? ourOpt.silent : true; | |||
| ourOpt.cwdbase = typeof ourOpt.cwdbase === 'boolean' ? ourOpt.cwdbase : false; | |||
| ourOpt.unique = typeof ourOpt.unique == 'string' || | |||
There was a problem hiding this comment.
use ===, just a styled preference
There was a problem hiding this comment.
Needs to be changed to uniqueBy if we decide on that name.
index.js
Outdated
| @@ -66,7 +68,7 @@ function globStream(globs, opt) { | |||
|
|
|||
| // Then just pipe them to a single unique stream and return it | |||
| var aggregate = new Combine(streams); | |||
| var uniqueStream = unique('path'); | |||
| var uniqueStream = unique(ourOpt.unique); | |||
There was a problem hiding this comment.
Needs to be changed to uniqueBy if we decide on that name.
phated
approved these changes
Feb 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #76
Support custom
uniquefiltering through option, or default to 'path' if custom value not provided.