Skip to content

Commit 4ab4aed

Browse files
sttkphated
authored andcommitted
Update: Pass updated eslint rules
1 parent ef7def3 commit 4ab4aed

File tree

8 files changed

+15
-11
lines changed

8 files changed

+15
-11
lines changed

.eslintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"extends": "gulp",
33
"rules": {
4-
"max-statements": [1, 40]
4+
"max-statements": [1, 40],
5+
"no-console": "off"
56
}
67
}

lib/versioned/^3.7.0/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function execute(opts, env, config) {
5555
}
5656
if (opts.tasksJson) {
5757
tree = taskTree(gulpInst.tasks);
58-
if (config.description && isString(config.description)) {
58+
if (config.description && typeof config.description === 'string') {
5959
tree.label = config.description;
6060
} else {
6161
tree.label = 'Tasks for ' + tildify(env.configPath);

lib/versioned/^3.7.0/task-tree.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ module.exports = function(tasks) {
2323
task.nodes.push(child);
2424
});
2525
});
26-
return { label: 'Tasks', nodes: arr, };
26+
return { label: 'Tasks', nodes: arr };
2727
};

test/.eslintrc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
{
2-
"extends": "gulp/test"
2+
"extends": "gulp/test",
3+
"rules": {
4+
"no-console": "off"
5+
}
36
}

test/config-flags-series.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ var path = require('path');
66
var skipLines = require('gulp-test-tools').skipLines;
77
var eraseTime = require('gulp-test-tools').eraseTime;
88
var eraseLapse = require('gulp-test-tools').eraseLapse;
9-
var runner = require('gulp-test-tools').gulpRunner;
109

1110
var fixturesDir = path.join(__dirname, 'fixtures/config');
1211
var runner = require('gulp-test-tools').gulpRunner({ verbose: false }).basedir(fixturesDir);

test/fixtures/gulpfiles/with-desc-and-flags.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ clean.description = 'Delete dist folder';
77
gulp.task(clean);
88

99
gulp.task('scripts', scripts);
10-
function scripts() {};
10+
function scripts() {}
1111
scripts.description = 'Bundles JavaScript';
1212

1313
var styles = function() {};
@@ -24,13 +24,13 @@ build.flags = {
2424
gulp.task('build', build);
2525

2626
gulp.task('serve', serve);
27-
function serve() {};
27+
function serve() {}
2828
serve.description = 'Serves files reloading';
2929
serve.flags = {
3030
'--lr': 'with live reloading',
3131
};
3232

33-
function watch() {};
33+
function watch() {}
3434
gulp.task('watch', watch);
3535
watch.description = 'Watch files and build on change';
3636

test/fixtures/test-error-module.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
1+
/* eslint no-unreachable: off */
12
throw new Error('from error module');
23
console.log('inside error module');

test/lib/task-tree.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@ describe('lib: taskTree', function() {
2828
label: 'test',
2929
type: 'task',
3030
nodes: [
31-
{ label: 'dep1', type: 'task', nodes: [], },
32-
{ label: 'dep2', type: 'task', nodes: [], },
31+
{ label: 'dep1', type: 'task', nodes: [] },
32+
{ label: 'dep2', type: 'task', nodes: [] },
3333
],
3434
},
3535
{
3636
label: 'test2',
3737
type: 'task',
3838
nodes: [
39-
{ label: 'dep3', type: 'task', nodes: [], },
39+
{ label: 'dep3', type: 'task', nodes: [] },
4040
],
4141
},
4242
{

0 commit comments

Comments
 (0)