Update: Pass updated eslint rules

gulpjs · Mar 13, 2019 · 4ab4aed · 4ab4aed
1 parent ef7def3
commit 4ab4aed
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 11 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -1,6 +1,7 @@
 {
   "extends": "gulp",
   "rules": {
-    "max-statements": [1, 40]
+    "max-statements": [1, 40],
+    "no-console": "off"
   }
 }
diff --git a/lib/versioned/^3.7.0/index.js b/lib/versioned/^3.7.0/index.js
@@ -55,7 +55,7 @@ function execute(opts, env, config) {
     }
     if (opts.tasksJson) {
       tree = taskTree(gulpInst.tasks);
-      if (config.description && isString(config.description)) {
+      if (config.description && typeof config.description === 'string') {
         tree.label = config.description;
       } else {
         tree.label = 'Tasks for ' + tildify(env.configPath);

diff --git a/lib/versioned/^3.7.0/task-tree.js b/lib/versioned/^3.7.0/task-tree.js
@@ -23,5 +23,5 @@ module.exports = function(tasks) {
       task.nodes.push(child);
     });
   });
-  return { label: 'Tasks', nodes: arr, };
+  return { label: 'Tasks', nodes: arr };
 };
diff --git a/test/.eslintrc b/test/.eslintrc
@@ -1,3 +1,6 @@
 {
-  "extends": "gulp/test"
+  "extends": "gulp/test",
+  "rules": {
+    "no-console": "off"
+  }
 }
diff --git a/test/config-flags-series.js b/test/config-flags-series.js
@@ -6,7 +6,6 @@ var path = require('path');
 var skipLines = require('gulp-test-tools').skipLines;
 var eraseTime = require('gulp-test-tools').eraseTime;
 var eraseLapse = require('gulp-test-tools').eraseLapse;
-var runner = require('gulp-test-tools').gulpRunner;
 
 var fixturesDir = path.join(__dirname, 'fixtures/config');
 var runner = require('gulp-test-tools').gulpRunner({ verbose: false }).basedir(fixturesDir);

diff --git a/test/fixtures/gulpfiles/with-desc-and-flags.js b/test/fixtures/gulpfiles/with-desc-and-flags.js
@@ -7,7 +7,7 @@ clean.description = 'Delete dist folder';
 gulp.task(clean);
 
 gulp.task('scripts', scripts);
-function scripts() {};
+function scripts() {}
 scripts.description = 'Bundles JavaScript';
 
 var styles = function() {};
@@ -24,13 +24,13 @@ build.flags = {
 gulp.task('build', build);
 
 gulp.task('serve', serve);
-function serve() {};
+function serve() {}
 serve.description = 'Serves files reloading';
 serve.flags = {
   '--lr': 'with live reloading',
 };
 
-function watch() {};
+function watch() {}
 gulp.task('watch', watch);
 watch.description = 'Watch files and build on change';
 

diff --git a/test/fixtures/test-error-module.js b/test/fixtures/test-error-module.js
@@ -1,2 +1,3 @@
+/* eslint no-unreachable: off */
 throw new Error('from error module');
 console.log('inside error module');
diff --git a/test/lib/task-tree.js b/test/lib/task-tree.js
@@ -28,15 +28,15 @@ describe('lib: taskTree', function() {
           label: 'test',
           type: 'task',
           nodes: [
-            { label: 'dep1', type: 'task', nodes: [], },
-            { label: 'dep2', type: 'task', nodes: [], },
+            { label: 'dep1', type: 'task', nodes: [] },
+            { label: 'dep2', type: 'task', nodes: [] },
           ],
         },
         {
           label: 'test2',
           type: 'task',
           nodes: [
-            { label: 'dep3', type: 'task', nodes: [], },
+            { label: 'dep3', type: 'task', nodes: [] },
           ],
         },
         {