Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slashes from links in plugin list #84

Closed
unconfident opened this issue Mar 23, 2018 · 3 comments
Closed

Remove trailing slashes from links in plugin list #84

unconfident opened this issue Mar 23, 2018 · 3 comments

Comments

@unconfident
Copy link

Didn't find where sources of https://gulpjs.com/plugins/ page located so posting here instead.

NPM website has updated recently and now links containing a slash after package name do not resolve correctly, resulting in a 404 page. Compare: with, without

Code in question:

<!--                                          this slash ↴ -->
<a ng-href="https://www.npmjs.com/package/{{plugin.name}}/" target="_blank" title="Install" class="title" ng-bind="plugin.name"></a>
@yocontra
Copy link
Member

Wow, that is really crummy behavior for their website. My gut says they should fix it, but if you send a PR to remove the slash we can merge it.

@unconfident
Copy link
Author

I don't think plugins page is a part of this repository, at least I wasn't able to find it.

My gut says they should fix it

Yeah, I agree but knowing how it is, it will probably take them multiple years to do so. Maybe they iterate quicker on the website than they do on the cli tool though. I'm also not seeing a public repo with sources for their main website anywhere so maybe it's private

@unconfident
Copy link
Author

Looks like they fixed it on their end, trailing slashes now removed with a redirect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants