Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider inlining remove-bom-buffer logic #5

Closed
phated opened this issue Jan 10, 2022 · 0 comments · Fixed by #8
Closed

Consider inlining remove-bom-buffer logic #5

phated opened this issue Jan 10, 2022 · 0 comments · Fixed by #8
Projects
v5

Comments

@phated
Copy link
Member

phated commented Jan 10, 2022

In trying to remove dependencies in the gulp chain, we should look into removing remove-bom-buffer and inlining the logic into this project.
@phated phated added this to To do in v5 via automation Jan 10, 2022
@sttk sttk mentioned this issue Mar 26, 2022
Merged
@phated phated closed this as completed in #8 Apr 18, 2022
v5 automation moved this from To do to Done Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
v5
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Require encoding option to avoid inspecting chunks for UTF-8 encoding sttk/remove-bom-stream
1 participant
@phated