Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add CLI flag to specify opcode variant #4

Closed
pushfoo opened this issue Nov 22, 2022 · 3 comments
Closed

Feature request: Add CLI flag to specify opcode variant #4

pushfoo opened this issue Nov 22, 2022 · 3 comments

Comments

@pushfoo
Copy link

pushfoo commented Nov 22, 2022

Running a source file containing SCHIP or XO-CHIP instructions (ie hires) with -r / --run appears to only partially work.

For example, hires assembles correctly to 00FF, but the instruction is interpreted in CHIP-8 mode and produces an invalid opcode error.

It would be easier to allow manually specifying the opcode variant as a CLI flag than to try to write auto-detect logic.

@pushfoo
Copy link
Author

pushfoo commented Nov 22, 2022

This was already added, just further down in the docs than expected.

It may be a good idea to move the presets section above the quirks section in the README to make this more obvious for other users.

@pushfoo pushfoo closed this as completed Nov 22, 2022
@gulrak
Copy link
Owner

gulrak commented Nov 22, 2022

Yeah, the readme is not that well organized, I'll see what I can do. Thanks for the comment.

@pushfoo
Copy link
Author

pushfoo commented Nov 22, 2022

Are you open to contributors using markdown tables and splitting the README into multiple documents? I don't know what the best practices for documenting C++ projects are considered to be, so I'd appreciate your input on that before jumping in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants