Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The CMake build definition doesn't contain a version #148

Closed
robbert-vdh opened this issue Jun 10, 2022 · 1 comment · Fixed by #149
Closed

The CMake build definition doesn't contain a version #148

robbert-vdh opened this issue Jun 10, 2022 · 1 comment · Fixed by #149
Labels
enhancement New feature or request
Milestone

Comments

@robbert-vdh
Copy link

I recently replaced Boost.Filesystem with ghc::filesystem in yabridge. I'm using Meson, and during ordinary builds the ghc_filesystem dependency resolves to a subproject wrap dependency contained within the repo, but when packaging yabridge for distro repos they usually want to use their own repo dependencies instead of vendored ones. In theory that should work without any changes if the library ships a pkgconfig file or a CMake build definition (in ghc::filesystem's case though I had to manually add modules : 'ghcFilesystem::ghc_filesystem' to the definition because it somehow doesn't export that by default like most other CMake dependencies do). The problem is that while this in theory works, the definitions in /usr/lib/cmake/ghc_filesystem don't contain any versions. So the following dependency will fail to resolve as the version bound cannot be satisfied:

ghc_filesystem_dep = dependency('ghc_filesystem', modules : 'ghcFilesystem::ghc_filesystem', version : '>=1.5.0')

Could you please consider adding a version number to the project? Using unversioned dependencies can otherwise result in all sorts of problems.

@gulrak
Copy link
Owner

gulrak commented Jun 14, 2022

Should be doable, Thanks for the report.

@gulrak gulrak added the enhancement New feature or request label Jun 15, 2022
@gulrak gulrak added this to the v1.5.14 milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants