Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Menu not working in IE 10 #31

Closed
mspanish opened this issue Apr 15, 2013 · 3 comments
Closed

Toggle Menu not working in IE 10 #31

mspanish opened this issue Apr 15, 2013 · 3 comments

Comments

@mspanish
Copy link

Hello guys - great work! I chose Gumby after looking pretty thoroughly at Foundation, Bootstrap, and others - mainly because Gumby is cleaner and just plain prettier than the rest :)

I'm on a Win8 Pro type tablet (the Samsung 12 inch with full Windows 8, not the RT version) - and I've found that the toggle menu on your homepage, as well as when you implement the Gumby CSS and JS found here on GitHub - doesn't work. If you resize the window, the little menu button shows up and all, but when you click it, nothing happens. If you keep clicking it, it finally works - but it's like you have to click 5 times, and even then it seems like a crapshoot whether the menu opens or not.

With Chrome, it works fine.

I realize people will not really be resizing it to that size on Windows, but people sometimes use multiple windows, so they may resize my site - and I just didn't want it to not be working in that case. Since the ResponsiveNav project I was using before Gumby http://responsive-nav.com/ works fine on my Win tablet, I thought maybe I would post this here as perhaps there is something a bit glitch in there.

Thanks again for all the hard work, this 'work at home' mom up in Alaska really appreciates it, my app will be much better for it :)

@mspanish
Copy link
Author

Ah Sorry I meant to point out, the problem is in IE 10 - both the "formerly known as Metro" version and the desktop browser.

@chambaz
Copy link
Contributor

chambaz commented Apr 18, 2013

Hey,

Thanks for posting the issue. I have a feeling this is to do with our tap event implementation. There's seems to be too much inconsistency when it comes to the touch events mobile devices support. When we move over to Zepto (very soon!) I will be using their built in touch events which will hopefully solve the issue, if not I'll be reverting back to trusty click events.

In the meantime I believe defaulting to the click event should fix the issue for you, try editing the detectClickEvent method in the Gumby object so that it always returns 'click'. You'll need to copy this change over to gumby.min.js if you are using the optimised file.

Gumby.prototype.detectClickEvent = function() {
    // Default to click event 
    /*if(Modernizr.touch) {
        this.setupTapEvent();
        return 'gumbyTap';
    } else {
        return 'click';
    }*/

    return 'click';
};

@chambaz
Copy link
Contributor

chambaz commented May 14, 2013

Hey, we no longer use jQuery special events and have moved to jQuery 1.9.1. jQuery mobile provides us with touch events, hopefully this should fix the IE10 issues you were experiencing.

@chambaz chambaz closed this as completed May 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants