Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make selected option for <MultiSelect> and <SearchMultiSelect> consistent #46

Open
jscottsmith opened this issue Sep 26, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@jscottsmith
Copy link
Collaborator

Property for indicating selection is inconsistent.

<SearchMultiselect> uses isSelected
<Multiselect> uses selected

We should pick one over the other and deprecate. The question is which do we prefer? :thonk:

@edrpls
Copy link

edrpls commented Sep 26, 2018

I think we usually use the is- prefix for almost everything, so that would be consistent with our codebases in general.

Should the PR should support both methods and warn about deprecation, or remove the old one altogether and be released as a minor update? If we support both I guess it could be just a patch?

@jscottsmith
Copy link
Collaborator Author

jscottsmith commented Sep 26, 2018

I prefer isSelected too.

Should the PR should support both methods and warn about deprecation.

Yes. I'm thinking a patch makes this an easy update.

@jscottsmith jscottsmith added the enhancement New feature or request label Sep 26, 2018
@edrpls
Copy link

edrpls commented Sep 26, 2018

Yep, that sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants