Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gumtree showing wrong diff portions for c# source files #34

Closed
irajdeep opened this issue Sep 7, 2016 · 4 comments
Closed

Gumtree showing wrong diff portions for c# source files #34

irajdeep opened this issue Sep 7, 2016 · 4 comments
Assignees
@jrfaller
Labels
bug

Comments

@irajdeep
Copy link

irajdeep commented Sep 7, 2016

screen shot 2016-09-07 at 8 31 43 pm

screen shot 2016-09-07 at 8 32 16 pm

Showing wrong diff for above 2 sample c# source files
@jrfaller
Copy link
Member

jrfaller commented Sep 8, 2016

Ok I was sure there was a problem. Maybe it's coming from srcml giving wrong positions to ast nodes... Could you check the raw result of the srcml command?

@irajdeep
Copy link
Author

irajdeep commented Sep 8, 2016

Sure,I will look into it and update the result here

@jrfaller jrfaller added the bug label Sep 9, 2016
@jrfaller jrfaller self-assigned this Sep 12, 2016
@jrfaller
Copy link
Member

OK, head of develop branch should fix this issue. Can you check?

@irajdeep
Copy link
Author

irajdeep commented Sep 12, 2016 •
edited
Loading

screen shot 2016-09-12 at 4 12 48 pm

screen shot 2016-09-12 at 4 12 39 pm

Awesome ! The issue seems to have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrfaller jrfaller

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrfaller @irajdeep