Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin misses use of deprecated interface properties #5

Closed
ecraig12345 opened this issue May 15, 2020 · 2 comments · Fixed by #6
Closed

Plugin misses use of deprecated interface properties #5

ecraig12345 opened this issue May 15, 2020 · 2 comments · Fixed by #6
Labels

Comments

@ecraig12345
Copy link
Contributor

One feature this plugin is missing compared to the tslint deprecation rule is detecting usage of deprecated interface/type properties. For example:

interface Thing1 {
  /** @deprecated */
  foo?: string;
}
const a: Thing1 = { foo: 'b' }; // should be an error
a.foo = 'c'; // correctly detected as error

type Thing2 = {
  /** @deprecated */
  foo?: string;
}
const b: Thing2 = { foo: 'c' }; // should be an error
b.foo = 'd'; // correctly detected as error
@gund
Copy link
Owner

gund commented May 16, 2020

Hi, as already mentioned - I cannot fix/improve this plugin at this point in time.

You are welcome to open a PR for this feature if you want.

@gund
Copy link
Owner

gund commented Jun 3, 2020

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund gund added the released label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants