Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Angular 15 #493

Closed
msgoloborodov opened this issue Dec 23, 2022 · 4 comments
Closed

Support for Angular 15 #493

msgoloborodov opened this issue Dec 23, 2022 · 4 comments

Comments

@msgoloborodov
Copy link
Contributor

Can you update ng-dynamic-component to support Angular 15, please?

@gund
Copy link
Owner

gund commented Dec 24, 2022

You should be able to just use the latest version with Angular 15 as is, unless there is some error you are getting?

@msgoloborodov
Copy link
Contributor Author

Yes, it works fine with Angular 15, but Angular 14 also installed.
So it will be nice to have version of ng-dynamic-component with angular 15 in deps.

@gund
Copy link
Owner

gund commented Dec 27, 2022

But the library does not install angular in it's dependencies, only references angular as a peer dependency:

"peerDependencies": {
"@angular/common": ">=14.1.3",
"@angular/core": ">=14.1.3",
"rxjs": ">=6.0.0"
},
"dependencies": {
"tslib": "^2.0.0"
}

So I'm not quite sure this is a problem of this package as it's version range is compatible with Angular 14+.

@msgoloborodov
Copy link
Contributor Author

Fine! Sorry, I looked at another package.json in a root dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants