Boostrapping Patch command #18
Conversation
|
Thanks a lot @sfc-gh-japatel, that's a great start!
Looking forward to it. @aalmiray, for some reason this hasn't triggered a PR build run on GH Actions. Could anything have been broken by the latest release related work by any chance? |
|
Ah, seems it's here where it went missing: 5885d1d#diff-5dbf1a803ecc13ff945a08ed3eb09149a83615e83f15320550af8e3a91976446L21-L23. |
|
Oops. I removed the PR trigger for regular build. My mistake. |
|
No worries. Could you bring it back? |
|
Done 9598e8c |
|
Thanks, @aalmiray! |
- kcctl get loggers - kcctl get loggers -p com.snowflake.kafka.connector - kcctl patch logger com.snowflake.kafka.connector -l INFO
|
Hey @sfc-gh-japatel, thanks for the update! Could you run |
| @Inject | ||
| ConfigurationContext context; | ||
|
|
||
| @CommandLine.Option(names = { "-p", "--path" }, description = "Path of the connector", defaultValue = DEFAULT_PATH) |
There was a problem hiding this comment.
What's the "path" of a connector?
There was a problem hiding this comment.
Connector path is usually the root path of the connector based on the java package name. Or it can a single class name. I am ok to change the name if path doesnt seem correct.
There was a problem hiding this comment.
Hey @sfc-gh-japatel, thanks for the update! Could you run
mvn license:formatand commit the result (currently, the license headers are missing from the new files)? Could you also update the output of kcctl help in the README, showing the new command? Other than that, are you planning more changes, or is it good to go from your PoV?
Thanks @gunnarmorling
Ran the mvn command.
Added patch in help section of kcctl.
These are the only changes I am planning from loggers perspective.
|
Rebased and applied. Thanks a lot, @sfc-gh-japatel! Note I've split up |
#15
Notes:
mvn compile quarkus:dev -Dquarkus.args='patch logger com.snowflake.kafka.connector -l INFO' -Dsuspend