Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional data on response object #66

Closed
gunthercox opened this issue Oct 19, 2015 · 5 comments
Closed

Support additional data on response object #66

gunthercox opened this issue Oct 19, 2015 · 5 comments

Comments

@gunthercox
Copy link
Owner

Serialized response lists should be a list of json objects so that additional data such can be added in the future.

Current format:

["Response text", 4]

New format:

{
    "text": "Response text",
    "occurrence": 4
}
@DarkmatterVale
Copy link
Collaborator

This sounds like a good idea. You might also want to think about providing the POS tags of the sentence in the new format. Although it only takes a short amount of time to calculate part of speech for every word, on databases that are large that time could add up. The format that I propose would be something similar to this:

{
     "text": "Response text",
     "pos_tags": [('Response', 'NN'), ('text', 'NN')],
     "occurrence": 4
}

@gunthercox
Copy link
Owner Author

@DarkmatterVale Definitely, I agree.

@DarkmatterVale
Copy link
Collaborator

Have you had a chance to work on updating this? If so, what have your results shown? Is there any performance improvement using the current logic adapters?

@gunthercox
Copy link
Owner Author

I haven't had a chance to work on this yet. I was thinking of implementing it over this upcoming weekend.

@DarkmatterVale
Copy link
Collaborator

Ok, just checking in...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants