Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fnv_hash_vec function used to downsample poiuntcloud has collisions on mirrored points #130

Open
Liquidmasl opened this issue Aug 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Liquidmasl
Copy link

This might not be a problem if all points are always moved into the positive domain. but if not points that are mirrored sometimes collide.

1. 
Original: ([0.89963308, 0.30712294, 0.81770174])
Mirrored: ([-0.89963308, 0.30712294, 0.81770174])

2. 
Original: ([0.76068334, 0.49337516, 0.68670659])
Mirrored: ([-0.76068334, 0.49337516, 0.68670659])

3. 
Original: ([0.38544234, 0.94407035, 0.39409715])
Mirrored: ([-0.38544234, 0.94407035, 0.39409715])

... and so on.

anyway, this might lead to some issued if the points are not all put in the positive domain.

@guochengqian
Copy link
Owner

thanks for letting me know. I will look into this in next week.

@guochengqian guochengqian added the bug Something isn't working label Aug 17, 2023
@Liquidmasl
Copy link
Author

Liquidmasl commented Aug 21, 2023

we just added that to the top of the hash function, should be relatively fast and solves the issue as far as i tested it

# move all vertices to positive space
arr -= np.min(arr, axis=0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants