Graph Management #47
Merged
Graph Management #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fMeow
reviewed
Nov 25, 2020
src/graph.rs
Outdated
| use serde::{Deserialize, Serialize}; | ||
| use typed_builder::TypedBuilder; | ||
|
|
||
| pub const GHARIAL_API_PATH: &str = "_api/gharial"; |
There was a problem hiding this comment.
Is GHARIAL_API_PATH a typo? Or am I missed something?
Plus, what about hide this const inside crate(pub(crate))? This path is a implementation detail to me, and thus should be hidden from user.
There was a problem hiding this comment.
For some reason it's called gharial but I can rename it to "graph" for the const.
I changed both new const into pub(crate) as you requested
There was a problem hiding this comment.
That is fine, don't need to rename. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request provides basic named graph management:
Based on https://www.arangodb.com/docs/stable/http/gharial-management.html
Missing: