New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should line 74-75 in optimization_gpu.py be comment out? #32

Closed

rsindper opened this issue Oct 24, 2021 · 1 comment

rsindper commented Oct 24, 2021

This issue is about global steps calculation. Should line 74-75 in optimization_gpu.py be comment out?

I don't think they should be comment out since the global step update is still not done inside of 'apply_gradients', right?

Owner

guotong1988 commented Oct 25, 2021 •

edited

Loading

I have tested the code.
line-74-75 should be comment out. Or it will print +2-step per real-step.
More info:
#24

guotong1988 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment