Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose default ratio but allow fixed-ratio button to be shown #79

Closed
roddymunro opened this issue Jan 15, 2021 · 3 comments · Fixed by #80
Closed

Choose default ratio but allow fixed-ratio button to be shown #79

roddymunro opened this issue Jan 15, 2021 · 3 comments · Fixed by #80
Assignees
Labels
enhancement New feature or request

Comments

@roddymunro
Copy link

I have a custom ratio that I would like to be set when opening an image (2:1). However, I would also like users to have the option of changing the ratio themselves.

I have tried config.presetFixedRatioType = .alwaysUsingOnePresetFixedRatio(ratio: 2.0), but this doesn't allow the ratio to be changed.

I have also used config.addCustomRatio(byHorizontalWidth: 2, andHorizontalHeight: 1), but I see no way to set the default crop ratio.

Is there something I'm missing, or should this be a feature request? Thank you.

@guoyingtao
Copy link
Owner

@roddymunro I think this is a feature request. I can support this feature in the next release.

@guoyingtao guoyingtao added the enhancement New feature or request label Jan 15, 2021
@guoyingtao guoyingtao self-assigned this Jan 15, 2021
@guoyingtao
Copy link
Owner

guoyingtao commented Jan 18, 2021

@roddymunro I released Mantis 1.4.8. Can you check if it can solve this issue?
You can use MantisConfig.presetFixedRatioType = canUseMultiplePresetFixedRatio(defaultRatio: )

@guoyingtao guoyingtao reopened this Jan 18, 2021
@roddymunro
Copy link
Author

@guoyingtao Thank you, that seems to work nicely. I appreciate you doing this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants