This repository has been archived by the owner on Jul 17, 2022. It is now read-only.
静态文件支持 #1
Closed
静态文件支持 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @cooker 感谢你对此提交PR，不过为了方便你应该在描述中说明该如何测试它 |
|
@cooker 非常感谢你的贡献，不过我测试的过程中功能上还有些小问题，比如我访问http://localhost:8090/plugins/web/potatoes/abc/ 时 报错会提示 NOT FOUND potatoes/abc/.ftl 或许带/应该访问的是potatoes/abc/index.ftl |
guqing
suggested changes
Jan 21, 2022
|
|
||
| public class FileViewerTest { | ||
| public static void main(String[] args) throws IOException { | ||
| // String file = "F:\\IT\\Code\\halo-plugin-experimental\\build\\plugins\\plugin-potatoes-1.0-SNAPSHOT.zip"; |
There was a problem hiding this comment.
@cooker 这个测试文件只能运行在windows机器上而无法运行在ci或我的linux 可以将绝对路径改为相对路径或通过Files创建临时目录来编写
| //task zipStatic(type: Zip) { | ||
| // from 'src/main/resources/static/' | ||
| // include '*' | ||
| // include '*/*' |
| <div> | ||
| <p>Index abc</p> | ||
| </div> | ||
| </html> |
| <div> | ||
| <p>Index</p> | ||
| </div> | ||
| </html> |
guqing
suggested changes
Jan 21, 2022
| final PathMatcher pathMatcher = FileSystems.getDefault().getPathMatcher("glob:**/"+pluginId+"-*.jar"); | ||
| try { | ||
| final Path[] sourcePath = {null}; | ||
| Files.walkFileTree(path, new SimpleFileVisitor<Path>(){ |
There was a problem hiding this comment.
@cooker 我认为没有必要去遍历目录 效率太低了 特别时目录很深时，在 deployment 模式下通过
Path path = event.getPlugin().getPluginPath().toAbsolutePath();已经可以获取到目录。
而在 development 模式下加载插件时使用的是 build/classes的内容因此实际是没有使用jar包的但是这里的静态文件加载还是依赖jar并且还解压了，我认为在开发模式下应该区别对待 可以直接通过插件类加载器获取到静态文件的目录直接复制到 halo的工作目录即可 无需使用 new ZipFile(args)处理,运行模式可以通过event.getPlugin().getRuntimeMode()来获取
|
hi @cooker 此PR是否还在继续 |
|
此 PR 太久未活跃 我将关闭它 如有后续可以重新open |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
测试流程
以potatoes 项目为例，在resources/static 新增需要的js、css、flt等静态资源。并build（打包）
本地调试