Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditional check to install poetry for PowerShell #4

Open
gurashish1singh opened this issue Oct 17, 2022 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@gurashish1singh
Copy link
Owner

gurashish1singh commented Oct 17, 2022

if [[ $(command -v poetry) ]]; then

The above conditional to check if poetry is installed to the user's path in the shell script, setup.sh only works for GitBash and Unix-like terminals. This check does not work on PowerShell.
image

Furthermore, poetry installation fails due to a ModuleNotFoundError:
image

AC:

  • Update the conditional to check if poetry is already installed to be successful on PowerShell
  • Fix the ModuleNotFoundError (full error stack attached)

poetry-installer-error-xodgg7gb.log

@gurashish1singh gurashish1singh added bug Something isn't working enhancement New feature or request labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant