Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize NotifyChanges method #5

Open
gus-sosa opened this issue Aug 13, 2017 · 2 comments
Open

Factorize NotifyChanges method #5

gus-sosa opened this issue Aug 13, 2017 · 2 comments

Comments

@gus-sosa
Copy link
Owner

Call two methods inside NotifyChanges:

  1. For creating the toast's visual component
  2. For creating the toast's action component

this helps in the future if it needs to change the implementation of one of this functionality

@gus-sosa gus-sosa reopened this Aug 15, 2017
@gus-sosa
Copy link
Owner Author

gus-sosa commented Aug 15, 2017

The previous comment by itself does not make sense, but if I would want to send notifications via email or other way, NotifyChanges has to be factorized in order to allow other ways to notify.

Some of these ways:

  • Send email
  • Create a new file by notification
  • Send notification to other application which does something with this notification

@gus-sosa
Copy link
Owner Author

@weedkiller , detect a file should be something easy to do. That might be implemented in FileWatcher.cs

Although I want to refactor/redesign this because at the pretty beginning I only wanted to see the toast notification for changes in a folder.

Now, it might be interesting to add some features, for that reason before writing any line of code. I will rethink the design/architecture of the code to be able to add new features easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant