Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify the presence of box checksums #74

Closed
marcindulak opened this issue Nov 11, 2017 · 4 comments
Closed

verify the presence of box checksums #74

marcindulak opened this issue Nov 11, 2017 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@marcindulak
Copy link

marcindulak commented Nov 11, 2017

curl https://app.vagrantup.com/gusztavvargadr/boxes/w10e-vs17c | python3 -m json.tool  | grep checksum

https://groups.google.com/forum/#!topic/vagrant-up/V0E4PAajM-g

@marcindulak marcindulak changed the title Investigate a possibility of including box checksums verify the presence of box checksums Nov 11, 2017
@gusztavvargadr
Copy link
Owner

@marcindulak sorry, I'm not sure what is your point here, can you be a bit more specific please?

@marcindulak
Copy link
Author

Since you are one of the few maintainers of vagrant boxes on app.vagrantup.com who try to keep their boxes in a good shape I thought you will be interested in the checksum problem, discovered recently https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878759

I don't think we need to do anything about this now, but it's good to follow this issue and if vagrant comes up with a solution, adapt the boxes. Basically the debian developers discovered that the following command is not failing:

$ vagrant box add --checksum-type sha256 --checksum 1234 --provider virtualbox gusztavvargadr/w10e-vs17c
==> box: Loading metadata for box 'gusztavvargadr/w10e-vs17c'
    box: URL: https://vagrantcloud.com/gusztavvargadr/w10e-vs17c
==> box: Adding box 'gusztavvargadr/w10e-vs17c' (v0.8.0) for provider: virtualbox
    box: Downloading: https://vagrantcloud.com/gusztavvargadr/boxes/w10e-vs17c/versions/0.8.0/providers/virtualbox.box
==> box: Successfully added box 'gusztavvargadr/w10e-vs17c' (v0.8.0) for 'virtualbox'!

@gusztavvargadr
Copy link
Owner

@marcindulak thanks for the suggestion and the details, I'll check this for the the upcoming releases. If you have any more information or suggestions later, please let me know.

Indeed, I try to publish boxes of a quality which I'd expected from other publish boxes as well :) Please let me know if you miss a box you'd need or you notice anything in general which could be improved. Thanks!

@gusztavvargadr gusztavvargadr added the enhancement New feature or request label Nov 12, 2017
@gusztavvargadr gusztavvargadr added this to the next milestone Jan 5, 2020
@gusztavvargadr
Copy link
Owner

@marcindulak FYI I have started publishing box checksums as Vagrant Cloud seems to have support it for now. Not visible on the UI yet and not sure if the Vagrant client already verifies these, but if you think, the JSON version of the boxes contain the information already, like:

https://app.vagrantup.com/gusztavvargadr/boxes/windows-server.json

I'm closing this now but please let me know if there's anything else I can do for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants