Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely slow for large files #84

Closed
Nudin opened this issue Jun 22, 2022 · 2 comments
Closed

Extremely slow for large files #84

Nudin opened this issue Jun 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Nudin
Copy link

Nudin commented Jun 22, 2022

Describe the bug
I tried to use the hosts file from StevenBlack with hostctl. When importing it, it takes 16 minutes.

To Reproduce
Steps to reproduce the behavior:

curl https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts > hosts.adblock
sudo hostctl -q add adblock --from hosts.adblock

Expected behavior
I expected it to be imported in a number of seconds.

System (please complete the following information):

  • OS: Linux
  • Version: latest Arch
@Nudin Nudin added the bug Something isn't working label Jun 22, 2022
@Nudin
Copy link
Author

Nudin commented Jun 22, 2022

After importing this, all operations take that long…

@guumaster
Copy link
Owner

Hi @Nudin the file is 3.25Mb of entries. This tool may no be the best for this task, as it is parsing the whole file each time you run a command. It'll need to be re-written entirely to handle that kind of content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants