Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processScript is generating invalid URL #115

Closed
gingur opened this issue Mar 17, 2021 · 4 comments
Closed

processScript is generating invalid URL #115

gingur opened this issue Mar 17, 2021 · 4 comments

Comments

@gingur
Copy link

gingur commented Mar 17, 2021

When running an inline module-shim script on a modern browser, the processScript is generating a URL ${pageBaseUrl}?${id++} that topLevelLoad is trying to load instead of returning the source,

@guybedford
Copy link
Owner

@gingur yes, that is how we handle the inline script tags, by assigning them a URL into the registry. What issue are you getting here?

@gingur
Copy link
Author

gingur commented Mar 18, 2021

It tries to load that url which is just a request to the page, so it returns text/html and blows up, never using the source provided. Using latest firefox to test.

@guybedford
Copy link
Owner

@gingur ah right, thanks for pointing out the line here as well - I've added a fix in 3ac57de, will release this soon.

@guybedford
Copy link
Owner

Fix released in 0.10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants