Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular 1.5 #21

Closed
rkusuma opened this issue Feb 28, 2016 · 6 comments
Closed

Support Angular 1.5 #21

rkusuma opened this issue Feb 28, 2016 · 6 comments
Assignees

Comments

@rkusuma
Copy link
Contributor

rkusuma commented Feb 28, 2016

Hi @guylabs ,

Can you make this support for angular 1.5.x ?

Thank You

@guylabs guylabs self-assigned this Feb 29, 2016
@guylabs
Copy link
Owner

guylabs commented Feb 29, 2016

Hi @rkusuma,

did you already test it with 1.5.x? If yes what were the issues? Currently I do not have that much time but if you already had a look at it then your findings would help fixing it quicker. The best would be if you could create a PR with the working version of the module with Angular 1.5.x.

Till now I didn't test it with the 1.5.x version.

Thanks and regards,

Guy

@torsten-sauer
Copy link

I created PR #26 with updated bower.json

@guylabs
Copy link
Owner

guylabs commented Jun 10, 2016

Hi @rkusuma,

thanks to the pull request #26 of @torsten-sauer we now have Angular 1.5 support. You can update to the master version to use it.

Thanks and regards,

Guy

@guylabs guylabs closed this as completed Jun 10, 2016
@rkusuma
Copy link
Contributor Author

rkusuma commented Jun 10, 2016

@guylabs thanks for your info.. and thanks @torsten-sauer for the PR

@rkusuma
Copy link
Contributor Author

rkusuma commented Jun 10, 2016

@guylabs you are not planning tag to version 0.4.5 ?

@guylabs
Copy link
Owner

guylabs commented Jun 21, 2016

Hi @rkusuma,

I think I will first add the flag mentioned in #23 and then do a new release.

Thanks and regards,

Guy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants