Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #28 invalid signature: 0x80014 #51

Merged
merged 4 commits into from
Mar 28, 2016
Merged

Conversation

hasanlussa
Copy link
Contributor

No description provided.

@DaSpawn
Copy link

DaSpawn commented Jan 11, 2016

This also is solved with node-stream-zip, I have rewrote/mostly finished the streaming reader and used node-stream-zip. My pull is #61 in case anyone else wondering/needing before merged

@matteocontrini
Copy link

Up

@JAForbes
Copy link

I'm experiencing this issue too.

@JAForbes
Copy link

Just to confirm: this PR fixed #28 for me.

@guyonroche
Copy link
Collaborator

I'm going to merge in this PR soon as it is the simplest fix for the invalid signature problem.
@DaSpawn - I still want to take a look at your work on the streaming reader though - getting that working is still one of the biggest missing pieces for this lib.

@guyonroche guyonroche merged commit 5160b03 into exceljs:master Mar 28, 2016
@DaSpawn
Copy link

DaSpawn commented Mar 28, 2016

I ended up writing an excel reader from scratch, https://github.com/DaSpawn/xlsx-stream-reader, I am not sure if you would be able to pull this into your project or not. My module does not parse styles (only stores as is), but it reads all sheets, shared strings, and formula stored values (not parse formulas) and uses events for data

The main reason I had to change this is your module uses blocking reads/writes and would hang my entire application while processing, so I had the reader wrapped into a child process to do the processing (just too much overhead/hack doing it like that). The reader was also exceptionally slow, and could not handle the 100x20000 excel sheets I was trying to read without taking a very long time and usually timing out the web page uploading the sheet (my processor can read those sheets in about 15 seconds)

Let me know if you need any more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants