Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProtestPage component #179

Open
guytepper opened this issue Oct 30, 2020 · 0 comments · May be fixed by #208
Open

Refactor ProtestPage component #179

guytepper opened this issue Oct 30, 2020 · 0 comments · May be fixed by #208
Assignees
@almogbhl
Labels
in progress type:refactor Describes redesign/code refactoring without changes in functionality zone:protest page Tasks related to the protest page.

Comments

@guytepper
Copy link
Owner

guytepper commented Oct 30, 2020 •
edited
Loading

The ProtestPage component code is very bloated, and lots of it's code can be removed / reused.

🧐 How to approach:

  • Take a deep breath and read the code thoroughly.
  • Think about how will you approach the refactor - taking it step by step, maybe it'll be more easy to rewrite from scratch - you decide.

💡 Things to keep in mind:

  • Are there parts of the code that already exists in other places in the codebase and can be reused?
    Can we extract some of the logic to other places, such as utils or ProtestStore?
  • Can some design elements be reused / omitted?
@almogbhl almogbhl self-assigned this Nov 8, 2020
@guytepper guytepper added in progress type:refactor Describes redesign/code refactoring without changes in functionality zone:protest page Tasks related to the protest page. and removed up for grabs labels Nov 8, 2020
@almogbhl almogbhl linked a pull request Nov 14, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almogbhl almogbhl

Labels
in progress type:refactor Describes redesign/code refactoring without changes in functionality zone:protest page Tasks related to the protest page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor protestPage guytepper/1km.co.il
2 participants
@guytepper @almogbhl